Add interfaces that were removed from upstream but containers/image uses #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cri-o/cri-o#899 is blowing up since these interfaces were removed. We can eventually fix containers/image to not use the interfaces, but for now, I think it makes more sense to add them back. |
|
@nalind @mtrmac @umohnani8 PTAL |
|
Code LGTM but Travis is not happy. |
nalind
reviewed
Sep 13, 2017
pkg/archive/archive.go
Outdated
| // UntarPath is a convenience function which looks for an archive | ||
| // at filesystem path `src`, and unpacks it at `dst`. | ||
| func UntarPath(src, dst string) error { | ||
| return defaultArchiver.UntarPath(src, dst) |
There was a problem hiding this comment.
Try NewDefaultArchiver().UntarPath(src, dst) here.
Add back in these interfaces since containers/image is using. archive.UntartPath archive.IsArchive Also add back this constant for containers/image. archive.HeaderSize Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
ACK. |
|
LGTM. |
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in these interfaces since containers/image is using.
archive.UntartPath
archive.IsArchive
Also add back this constant for containers/image.
archive.HeaderSize
Signed-off-by: Daniel J Walsh dwalsh@redhat.com