Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make homedir functions work on Windows #1084

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 6, 2021

Needed for containers/podman#12503

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Dec 6, 2021

@n1hility PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Dec 6, 2021

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rhatdan

@rhatdan rhatdan merged commit 4cd5fa1 into containers:main Dec 6, 2021
@n1hility
Copy link
Member

n1hility commented Dec 6, 2021

@rhatdan LGTM but as a disclaimer, technically Windows apps often use %LocalAppData%[name of app] -> which is [user's home]\AppData\Local\[e.g. Podman]) In my draft win podman machine PR I just kept the Linux podman conventions and planned to revisit since I wasn't sure if it should be Local\Containers\Podman or Local\Podman\Containers. Also there isn't really an equivalent of XDG_CONFIG_HOME, so something would have to be made up there. I personally think it's fine to leave it like this so, but up to you guys if we should be stricter adherents to the OS convention over an app convention.

@rhatdan
Copy link
Member Author

rhatdan commented Dec 7, 2021

I am fine with fixing this to match Microsoft, perhaps we just do a if runtime.GOOS="windows" or make the functions in separate windows source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants