Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: allow unknown backing fs with mountProgram #1512

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

giuseppe
Copy link
Member

if a mountProgram is specified, let it deal with an unknown backing file system instead of failing early. The error is kept when we use native overlay.

Closes: #1511

if a mountProgram is specified, let it deal with an unknown backing
file system instead of failing early.  The error is kept when we use
native overlay.

Closes: containers#1511

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 0697414 into containers:main Feb 22, 2023
@TomSweeneyRedHat
Copy link
Member

This smells like a ZeroDay fix, thoughts?

@giuseppe
Copy link
Member Author

This smells like a ZeroDay fix, thoughts?

good idea. Backported to 1.45: #1515

@TomSweeneyRedHat
Copy link
Member

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2173082 RHEL 8.9, and https://bugzilla.redhat.com/show_bug.cgi?id=2173089 RHEL 9.3.

I'm trying to create ZeroDAy BZs for 8.8 and 9.2 from those, but Bugzilla is being Bugzilla at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run podman after upgrading to 4.4.1
4 participants