overlay: Put should ignore ENINVAL for Unmount
#1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
reviewed
Aug 14, 2023
vrothberg
reviewed
Aug 14, 2023
It seems there are cases where underlying layers can be already unmounted in such case the layer directory is not removed and put fails early with `EINVAL` causing dangling directory for these layers. Following case may be a hidden underlying issue with `unmounting` of `c/stoage` which needs more investigation however prior discussion shows that this is a long standing issue in `storage` and which was never caught till containers#1607 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
put-ignore-einval
branch
from
c093e39 to
6469e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there are cases where underlying layers can be already unmounted in such case the layer directory is not removed and put fails early with
EINVALcausing dangling directory for these layers.Following case may be a hidden underlying issue with
unmountingofc/stoagewhich needs more investigation however prior discussion shows that this is a long standing issue instorageand which was never caught till #1607Closes: containers/podman#19491