store: serialize container deletion #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnsureRemoveAll already implements the trivial rm -rf attempt first, so there is no need to try it before calling EnsureRemoveAll. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
serialize the call to containersStore.Delete(id) since it attempts to recursively remove the graphroot directory. Doing so, it makes ineffective the other goroutine that attempts to remove safely the graphroot with EnsureRemoveAll. Depending on what goroutine is faster, there can be a flake like: 2023-09-26T17:49:02.6708666Z stderr: Error: cleaning up storage: removing container 6ebff2c6c6f5fe78c158956a88467ef7af6f6a7c3d40334d248c7b7409341230 root filesystem: 1 error occurred: * unlinkat /var/tmp/podman_test3482607530/root/overlay-containers/6ebff2c6c6f5fe78c158956a88467ef7af6f6a7c3d40334d248c7b7409341230/userdata/shm: device or resource busy Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
@edsantiago this could be the reason for the ".*/userdata/shm: device or resource busy" flake we see occasionally @vrothberg PTAL |
vrothberg
approved these changes
Sep 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
sure, opened here: containers/podman#20163 |
|
I have a feeling you will make @edsantiago very very very happy with this fix. The flakes haunted us for so long. |
|
LGTM |
|
OMG thank you so much @giuseppe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serialize the call to containersStore.Delete(id) since it attempts to recursively remove the graphroot directory.
Doing so, it makes ineffective the other goroutine that attempts to remove safely the graphroot with EnsureRemoveAll. Depending on what goroutine is faster, there can be a flake like:
2023-09-26T17:49:02.6708666Z stderr: Error: cleaning up storage: removing container 6ebff2c6c6f5fe78c158956a88467ef7af6f6a7c3d40334d248c7b7409341230 root filesystem: 1 error occurred: * unlinkat /var/tmp/podman_test3482607530/root/overlay-containers/6ebff2c6c6f5fe78c158956a88467ef7af6f6a7c3d40334d248c7b7409341230/userdata/shm: device or resource busy
it is a difficult to trigger condition, but I am hitting it constantly in: containers/crun#1312
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com