-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend PutLayer to optimize reusing data from existing layers #1830
Extend PutLayer to optimize reusing data from existing layers #1830
Conversation
When the caller provides neither OriginalDigest nor UncompressedDigest, only digest the layer once. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This allows us to correctly set (CompresedDigest, CompressedSize) when copying data from another layer; in that case we don't have the compressed data, so computing the size from compressedCounter sets an incorrect value. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
LayersByTOCDigest
), only digest uncompressed input once, not twiceCompressedSize
value to matchCompressedDigest
, so that we don't create layers with incorrect metadata.Motivated by containers/image#2288 .
Cc: @giuseppe (fairly low priority)