Update to Go 1.22 #2086
Merged
Update to Go 1.22 #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @Luap99 |
mtrmac
force-pushed
the
go1.22
branch
2 times, most recently
from
f0fbf28 to
9fce543
Compare
Luap99
reviewed
Sep 5, 2024
go.mod
Outdated
| @@ -1,7 +1,7 @@ | |||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
For consistency should we set this to 1.22.0 so that the toolchain line is removed like in the other projects?
I was thinking about updating the warning comment here to always say we never want the toolchain in go.mod
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... for the trivial cases where the loop body does not reference the iteration variable at all. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Leave anything requiring math/rand.Read alone. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and take advantage of the new features where it’s easy to do.