Use strings.Cut{,Prefix,Suffix} where appropriate #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions strings.CutPrefix and strings.CutSuffix are available since Go 1.20 and can be used instead of strings.Has* counterparts when the latter is followed by removing the prefix or suffix. This simplifies the code a bit, allowing for less mistakes. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. While at it, simplify UID/GID error message (as strconv.ParseUint error already contains the source string). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
In some places, using strings.Cut (available since Go 1.18) instead of strings.SplitN allows for simpler more readable code. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
/approve |
|
@mtrmac PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, kolyshkin, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, using
strings.Cut(available since Go 1.18) instead ofstrings.SplitNallows for simpler more readable code.Similarly, using
strings.CutPrefixandstrings.CutSuffix(available since Go 1.20)instead of their
strings.Has*counterparts allows for simpler code.