-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a number of testing & dependency issues #24
Conversation
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
…r does not exist. Signed-off-by: Erik Hollensbe <github@hollensbe.org>
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
…ths. Signed-off-by: Erik Hollensbe <github@hollensbe.org>
93ced02
to
350b440
Compare
I love just about everything in here. |
.travis.yml
Outdated
- sudo env AUTO_GOPATH=1 PATH="$PATH" ./hack/make.sh test-unit | ||
- AUTO_GOPATH=1 make docs | ||
- make install.tools | ||
- ./hack/make.sh validate-gofmt validate-pkg validate-lint validate-test validate-toml validate-vet validate-vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Travis may only be failing because this patch removes the 'validate-vendor' script, but leaves it in this list.
the unfortunate problem with jumping between pre-1.7 and 1.7 is the context package. It typically works with one or the other, and most of the libs have already ported to the 1.7 context package (as opposed to the golang.org third-party one) |
Ugh. IIRC we've got some targets (I think CentOS 7 and its RHEL upstream) that are still on 1.6. I don't think we're using ioutils.CancelReadCloser anywhere in storage itself, so if it isn't being used by containers/image, skopeo, or cri-o (buildah doesn't), I'd be tempted to drop the implementation of that type to side-step the issue. |
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
I've refreshed the branch and will monitor it to ensure tests pass. |
.travis.yml
Outdated
- make .gitvalidation | ||
- make build-binary | ||
- ./hack/make.sh cross | ||
- sudo ./hack/make.sh test-unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the go compiler's not in the default $PATH in Travis.
some pathing issue; I'll have to deal with this tomorrow, sorry |
Signed-off-by: Erik Hollensbe <github@hollensbe.org>
This should be passing now; the fundamental issue was some GOPATH muckery I missed and travis's sudo config has All in the last commit. PTAL. |
Sorry to press but the lint branch is getting pretty expansive, I was hoping we could discuss or finalize this somehow. |
I'm still going to need to get builds going on non-1.7 versions of go, but that's not a good reason to hold this up, as the tests pass in CI and on my box. |
Ok, I will put in a ticket for that and try to address it this week. |
That should be sorted by #30, assuming nothing in there is too outlandish. |
Please see the individual commits. Until this was done, I was unable to test
locally.
The virtualbox flip in particular is important if you have the kvm module
running but no qemu or libvirt vagrant provider, which doesn't install on
modern vagrant without a rubygems error. So, I think it's better to keep the
safe, easy-to-install version preferred, especially because vagrant was made to
run virtualbox.
I also incorporated github.com/LK4D4/vndr to manage dependencies.
I think it might be a good idea to setup a monorepo for all the
containers/
projects as a submodule to
vendor/
. This will help quite a bit with conflictsI think. cc @runcom @mtrmac
The integration-cli target doesn't exist because the dir doesn't exist. I don't
know if that's an intentional thing or not, but as an open source project it's
pretty much impossible to contribute from the outside without this information.
go as installed from package (at least on fedora) does not work to compile
golint and a few other things, so I decided it was best to get official 1.7.4
in there -- it'll also help if the debian/fedora packages mismatch.
Again, I couldn't test at all until these patches were made. All of them except
the .gitignore changes were required.