build: Some clean-ups for the shell completions #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names like bash_comp_dir and fish_comp_dir get missed when grepping for 'completion'. Note that the name of the directory is a plural, because it contains lots of completions for many different programs, just like the name of the pkgconfig variable. containers#1123 containers#1138
debarshiray
force-pushed
the
wip/rishi/build-clean-up-completion
branch
from
ad39ed7 to
a6d7104
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 7m 12s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #1123