-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/cmd, playbooks: Drop image prefix for fedora-toolbox #615
Merged
debarshiray
merged 1 commit into
containers:master
from
HarryMichal:drop-fedora-toolbox-image-prefix
Feb 19, 2021
Merged
src/cmd, playbooks: Drop image prefix for fedora-toolbox #615
debarshiray
merged 1 commit into
containers:master
from
HarryMichal:drop-fedora-toolbox-image-prefix
Feb 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build failed.
|
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Feb 12, 2021
Due to historical reasons, the 'fedora-toolbox' image hosted in Fedora's image registry[0] needed to have a special prefix (so called Fedora generational core). That puts more strain on the image registry because the toolbox images are periodically refreshed and the previous ones are kept in the registry. Also, the code of Toolbox needed to account for this. This special prefix is no longer required and so we'll start creating images simply called 'fedora-toolbox'. To be able to use them, Toolbox needs to be updated, too. containers#615
debarshiray
force-pushed
the
drop-fedora-toolbox-image-prefix
branch
from
February 12, 2021 14:05
d8a9142
to
4617f99
Compare
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Feb 12, 2021
The FGC namespace used to be required by the Fedora container guidelines, but not anymore [1]. [1] https://pagure.io/ContainerSIG/container-sig/issue/2 containers#615
debarshiray
force-pushed
the
drop-fedora-toolbox-image-prefix
branch
from
February 12, 2021 17:19
4617f99
to
d575318
Compare
Build failed.
|
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Feb 12, 2021
The FGC namespace used to be required by the Fedora container guidelines, but not anymore [1]. [1] https://pagure.io/ContainerSIG/container-sig/issue/2 containers#615
debarshiray
force-pushed
the
drop-fedora-toolbox-image-prefix
branch
from
February 12, 2021 18:09
d575318
to
67226a2
Compare
Build failed.
|
debarshiray
pushed a commit
to HarryMichal/toolbox
that referenced
this pull request
Feb 19, 2021
The FGC namespace used to be required by the Fedora container guidelines, but not anymore [1]. [1] https://pagure.io/ContainerSIG/container-sig/issue/2 containers#615
debarshiray
force-pushed
the
drop-fedora-toolbox-image-prefix
branch
from
February 19, 2021 13:22
67226a2
to
9ecbfa2
Compare
Build failed.
|
The FGC namespace used to be required by the Fedora container guidelines, but not anymore [1]. [1] https://pagure.io/ContainerSIG/container-sig/issue/2 containers#615
debarshiray
force-pushed
the
drop-fedora-toolbox-image-prefix
branch
from
February 19, 2021 13:48
9ecbfa2
to
f5bbe35
Compare
Build failed.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. Along the road I chose to update the f29/fedora-toolbox:29 image to the fedora-toolbox:32 image because I did not want to maintain two versions of images (the name changed some time ago[1]). I also introduced or modified a number of helper functions to make better use of the caching and default system recognition. [0] containers#517 [1] containers#615
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. Along the road I chose to update the f29/fedora-toolbox:29 image to the fedora-toolbox:32 image because I did not want to maintain two versions of images (the name changed some time ago[1]). I also introduced or modified a number of helper functions to make better use of the caching and default system recognition. [0] containers#517 [1] containers#615
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. Along the road I chose to update the f29/fedora-toolbox:29 image to the fedora-toolbox:32 image because I did not want to maintain two versions of images (the name changed some time ago[1]). I also introduced or modified a number of helper functions to make better use of the caching and default system recognition. [0] containers#517 [1] containers#615
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 26, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 28, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 31, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. [0] containers#615 containers#780
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 31, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. Seems like newer version of ShellCheck checks the validity of variable names (SC2153). This caused a false positive, so I silenced it. [0] containers#615 containers#780
HarryMichal
added a commit
that referenced
this pull request
May 31, 2021
The fedora-toolbox:32 image is the first of images in the renamed toolbox image repository[0]. With the change we can drop the pull_image_old() function because it was kept only for the old image. Seems like newer version of ShellCheck checks the validity of variable names (SC2153). This caused a false positive, so I silenced it. [0] #615 #780
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
May 31, 2021
Since the rewrite of the system test suite[0] we've relied on the Zuul playbooks for taking care of caching images using Skopeo for increasing the reliability of the tests (in the past the instability of the Fedora registry caused problems). This state is problematic if we want to use the tests in other environments than the Zuul CI. This moves the caching from Zuul into the system tests. Currently, Bats does not support officially suite-wide setup and teardown functions. The solution I chose was to add two new test files that are executed before and after all tests. This may complicate the execution of cherry-picked tests but that is not a very common use case anyway. The tests are now to some extent capable of adjusting to the host environment. This is meant in the sense of: I'm running on RHEL, the "default image" is UBI; I'm running on Fedora, the "default image" is fedora-toolbox. This mechanism relies on os-release, which is the same as what Toolbox itself uses. Along the road I chose to update the f29/fedora-toolbox:29 image to the fedora-toolbox:32 image because I did not want to maintain two versions of images (the name changed some time ago[1]). I also introduced or modified a number of helper functions to make better use of the caching and default system recognition. [0] containers#517 [1] containers#615 containers#774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to historical reasons, the 'fedora-toolbox' image hosted in Fedora's
image registry[0] needed to have a special prefix (so called Fedora
generational core). That puts more strain on the image registry because
the toolbox images are periodically refreshed and the previous ones are
kept in the registry. Also, the code of Toolbox needed to account for
this.
This special prefix is no longer required and so we'll start creating
images simply called 'fedora-toolbox'. To be able to use them, Toolbox
needs to be updated, too.
This cannot be merged until all required
fedora-toolbox
images areavailable for use.
Here's a link to the PR in Fedora's dist-git to remove the prefix.