-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
281be5c
to
66d2b8e
Compare
@mcastelino @egernst PTAL |
@chavafg can we enable IPv6 in our docker CI https://docs.docker.com/config/daemon/ipv6/ This will help catch issues easily. We should ignore IPv6 settings till we support them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to squash here?
Changes to two different agent implementations, makes sense to have them in a separate commit. We can revert one once we add ipv6 support. |
@amshinde I don't mind having one or two commits here, but please could you add a subsystem for each of your commit messages, identifying which component is modified: Or simply squash them. Up to you ! |
We ignore routes that have an ipv6 destination, since hyperstart agent does not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address. Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
We ignore routes that have an ipv6 destination, since kata agent does not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address. Fixes containers#672 Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>
66d2b8e
to
9bb9779
Compare
@sboeuf I have modified the commit message. |
@amshinde LGTM |
@sboeuf I see the fedora CI failing this time, even though I just changed the commit message.
I am going to rerun to see if I get the same error, but maybe a potential bug/race somewhere else in our code. |
@amshinde some race conditions in our unit tests... I have re-triggered a build already. |
We ignore routes that have an ipv6 destination, since we do not have support for ipv6 currently. We should do the same for default route that has an ipv6 gateway address.