Skip to content
This repository has been archived by the owner on Aug 4, 2022. It is now read-only.

v1.6rc docs reference v1.5 label #31

Closed
jjcollinge opened this issue Apr 19, 2018 · 2 comments
Closed

v1.6rc docs reference v1.5 label #31

jjcollinge opened this issue Apr 19, 2018 · 2 comments

Comments

@jjcollinge
Copy link

In the current v1.6rc docs, under the heading extensions the sample for labels references the v1.5 label expose rather than the v1.6 label enable.

<StatelessServiceType ServiceTypeName="WebServiceType">
  <Extensions>
      <Extension Name="Traefik">
        <Labels xmlns="http://schemas.microsoft.com/2015/03/fabact-no-schema">
          <Label Key="traefik.frontend.rule.example2">PathPrefixStrip: /a/path/to/strip</Label>
         <!-- This should be enable -->
         <Label Key="traefik.expose">true</Label>
         <!-- This should be enable -->
          <Label Key="traefik.frontend.passHostHeader">true</Label>
        </Labels>
      </Extension>
  </Extensions>
</StatelessServiceType>
@ldez
Copy link
Contributor

ldez commented Apr 19, 2018

@jjcollinge do you plan to make a PR about this?

@jjcollinge
Copy link
Author

Yes, I am travelling so raised this as a reminder to fix when I arrive.

jjcollinge added a commit to jjcollinge/traefik that referenced this issue Apr 19, 2018
Fix docs to use v1.6 labels rather than v1.5.
Reference issue: containous/traefik-extra-service-fabric#31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants