Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary ?? operator #107

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: Remove unnecessary ?? operator #107

merged 1 commit into from
Sep 10, 2024

Conversation

meyfa
Copy link
Member

@meyfa meyfa commented Sep 9, 2024

When updating to TypeScript 5.6, it now (correctly) complains:

src/api/jobs.ts(46,20): error TS2869: Right operand of ?? is
unreachable because the left operand is never nullish.

Hence, the unreachable code is removed.

Fixes #(issue)

Additional Context

TypeScript PR: #102

Checklist

  • The pull request title meets the Conventional Commits specification and optionally includes the scope, for example: feat: Add social login

When updating to TypeScript 5.6, it now (correctly) complains:

> src/api/jobs.ts(46,20): error TS2869: Right operand of ?? is
> unreachable because the left operand is never nullish.

Hence, the unreachable code is removed.
@meyfa meyfa requested a review from a team as a code owner September 9, 2024 19:58
@meyfa meyfa added the type::fix label Sep 9, 2024
@lusu007 lusu007 merged commit 5359660 into main Sep 10, 2024
4 checks passed
@lusu007 lusu007 deleted the fix/useless-coalescing branch September 10, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants