-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict with DBAL 2.11.0 #13
Conversation
Conflict wirth DBAL 2.11.0 see contao/contao#2359
What's the problem with |
doctrine/dbal#4282 - Which is a breaking change as the Query Builder before ignored empty query parts. The behavior to ignore empty query parts has been restored and will get released as patched version. Therefore potentially anyone using the Query builder is affected (unless explicitly checking for and ignoring empty strings). tbh, I did not know that empty query parts are ignored but I suspect there are some extensions out there that will stop working using that version of doctrine. |
@baumannsven pls add your bugs with console migration and DBAL... |
Please rebase the PR onto the correct branch. |
I wonder what branch this might be, considering this repo has only |
Sorry, my bad. I didn't realize this is not |
So how does this affect Contao? Where exactly does the issue occur? |
@baumannsven has more information, as he experienced the issue in the migrations, however he seems rather busy lately and might not be able to answer more closely. I'll try to reach out to him. |
This will need to be updated, as the resolution was not complete and we found another regression, see doctrine/dbal#4330. So the comflicting versions will be: 2.11.0 & 2.11.1. Still waiting to hear from @baumannsven though. 😞 |
Stale |
Conflict with DBAL 2.11.0
see contao/contao#2359