Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with DBAL 2.11.0 #13

Closed
wants to merge 1 commit into from
Closed

Conflict with DBAL 2.11.0 #13

wants to merge 1 commit into from

Conversation

zonky2
Copy link

@zonky2 zonky2 commented Sep 25, 2020

Conflict with DBAL 2.11.0
see contao/contao#2359

Conflict wirth DBAL 2.11.0
see contao/contao#2359
@zonky2 zonky2 changed the title Conflict wirth DBAL 2.11.0 Conflict with DBAL 2.11.0 Sep 25, 2020
@m-vo
Copy link
Member

m-vo commented Sep 25, 2020

What's the problem with doctrine/dbal 2.11.0?

@discordier
Copy link

What's the problem with doctrine/dbal 2.11.0?

doctrine/dbal#4282 - Which is a breaking change as the Query Builder before ignored empty query parts.

The behavior to ignore empty query parts has been restored and will get released as patched version.

Therefore potentially anyone using the Query builder is affected (unless explicitly checking for and ignoring empty strings).

tbh, I did not know that empty query parts are ignored but I suspect there are some extensions out there that will stop working using that version of doctrine.

@zonky2
Copy link
Author

zonky2 commented Sep 28, 2020

@baumannsven pls add your bugs with console migration and DBAL...

@leofeyer
Copy link
Member

leofeyer commented Oct 1, 2020

Please rebase the PR onto the correct branch.

@discordier
Copy link

Please rebase the PR onto the correct branch.

I wonder what branch this might be, considering this repo has only master and the PR is against master?

@leofeyer
Copy link
Member

leofeyer commented Oct 1, 2020

Sorry, my bad. I didn't realize this is not contao/contao. 🙈

@leofeyer
Copy link
Member

leofeyer commented Oct 1, 2020

So how does this affect Contao? Where exactly does the issue occur?

@discordier
Copy link

@baumannsven has more information, as he experienced the issue in the migrations, however he seems rather busy lately and might not be able to answer more closely. I'll try to reach out to him.

@discordier
Copy link

This will need to be updated, as the resolution was not complete and we found another regression, see doctrine/dbal#4330.

So the comflicting versions will be: 2.11.0 & 2.11.1.

Still waiting to hear from @baumannsven though. 😞

Base automatically changed from master to main January 18, 2021 16:15
@leofeyer
Copy link
Member

Stale

@leofeyer leofeyer closed this Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants