Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon layout_.svg and other disabled icons missing #1202

Closed
OMOSde opened this issue Nov 25, 2017 · 7 comments
Closed

Icon layout_.svg and other disabled icons missing #1202

OMOSde opened this issue Nov 25, 2017 · 7 comments
Assignees
@frontendschlampe
Labels
bug
Milestone
4.4

Comments

@OMOSde
Copy link

OMOSde commented Nov 25, 2017

Used on https://github.com/contao/core-bundle/blob/master/src/Resources/contao/dca/tl_theme.php#L451
@leofeyer leofeyer changed the title Icon layout_.svg missing in src/Resources/contao/themes/flexible/icons/ Icon layout_.svg and other disabled icons missing Nov 27, 2017
@leofeyer leofeyer added the bug label Nov 27, 2017
@leofeyer leofeyer added this to the 4.4.9 milestone Nov 27, 2017
@leofeyer
Copy link
Member

The following icons are missing:

  • css_.svg
  • modules_.svg
  • layout_.svg
  • sizes_.svg
  • theme_export_.svg

@frontendschlampe Could you please open the existing icons (without underscore), desaturate them and send them to me?

@leofeyer
Copy link
Member

Maybe we can generally desaturate icons via CSS or via the <feColorMatrix> SVG filter?

@frontendschlampe
Copy link
Contributor

The following icons are missing:

css_.svg
modules_.svg
layout_.svg
sizes_.svg
theme_export_.svg

@frontendschlampe Could you please open the existing icons (without underscore), desaturate them > and send them to me?

Yes - no problem

Maybe we can generally desaturate icons via CSS or via the SVG filter?

I have no experience with that - we have to try. But when I compare to "normal" pixel images and automatically desaturation it could have some unexpected results.

@leofeyer leofeyer mentioned this issue Nov 28, 2017
Closed
@leofeyer
Copy link
Member

it could have some unexpected results.

True.

@leofeyer leofeyer removed this from the 4.4.9 milestone Dec 14, 2017
@leofeyer
Copy link
Member

@frontendschlampe What about this ticket? 😉

@frontendschlampe
Copy link
Contributor

I'm sorry for delay. I will make them as soon as possible! :-(

@frontendschlampe frontendschlampe mentioned this issue Jun 19, 2018
Merged
leofeyer pushed a commit that referenced this issue Jun 22, 2018
@leofeyer
Add/improve some icons (see #1575).
f0ff185 
Description
-----------

- improve icon modules.svg
- add icons for #1202
- add icon for #1545

Commits
-------

abb6003 add/improve some icons
f14694e improve size of 2fa icons (same height like user icons)
d37484e improve module icon again
a86c900 delete single 2fa-icons and add user/admin icon with lock
aeaf343 improve size units of some icons
3922030 improve position of icon elements
0c427ba Run the gulp task.
@leofeyer leofeyer added this to the 4.4.20 milestone Jun 22, 2018
leofeyer added a commit that referenced this issue Jun 25, 2018
@leofeyer
Add the missing theme icons (see #1202).
53b2ab3
@leofeyer
Copy link
Member

I have added the icons in 53b2ab3. Thank you @frontendschlampe.

christian-kolb pushed a commit to christian-kolb/contao that referenced this issue Oct 11, 2018
@leofeyer
[Core] Add/improve some icons (see contao#1575).
ce1dc34 
Description
-----------

- improve icon modules.svg
- add icons for contao/core-bundle#1202
- add icon for contao/core-bundle#1545

Commits
-------

abb6003b add/improve some icons
f14694e4 improve size of 2fa icons (same height like user icons)
d37484eb improve module icon again
a86c900d delete single 2fa-icons and add user/admin icon with lock
aeaf343b improve size units of some icons
3922030e improve position of icon elements
0c427ba5 Run the gulp task.
@leofeyer leofeyer modified the milestones: 4.4.20, 4.4 May 14, 2019
leofeyer added a commit that referenced this issue Jan 16, 2020
@leofeyer
Always allow root pages in a custom navigation modules (see #1202)
6ac70ab 
Description
-----------

See contao/contao#72 (comment)

Commits
-------

21f6375d Revert 'Only allow root pages in a custom navigation if the language is added to the URL'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frontendschlampe frontendschlampe

Labels
bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
3 participants
@leofeyer @frontendschlampe @OMOSde