Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-5613,HMS-5614: search rpms and add popular repo tests #1008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rverdile
Copy link
Contributor

@rverdile rverdile commented Mar 5, 2025

Summary

Adds playwright tests for searching repository rpms and adding a popular repo

Testing steps

@jlsherrill
Copy link
Member

@jlsherrill
Copy link
Member

@rverdile rverdile force-pushed the pw-rpm-search branch 5 times, most recently from d09e388 to 3676bf4 Compare March 11, 2025 19:10
Copy link
Contributor

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like you committed the same file twice by accident after moving it, so that needs to be fixed 🧹 and one tiniest nit, which you can totally ignore if desired

looks nice, good job! 👏🏼🎉

@rverdile rverdile force-pushed the pw-rpm-search branch 2 times, most recently from 06b5bb0 to 31d08a9 Compare March 12, 2025 16:03
Copy link
Member

@Andrewgdewar Andrewgdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack on passing playwright tests!

Copy link
Contributor

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 😇 ack from me as well ✅

@rverdile rverdile force-pushed the pw-rpm-search branch 4 times, most recently from c86e6b1 to ceb243a Compare March 18, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants