-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-5617: package groups test #1018
Conversation
cd6bfa2
to
fd19c0f
Compare
d3de9e5
to
4a61bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, nice work on migrating and upgrading/extending the test! 👏🏼🎉
just one tiny nit 👀 if you wanted to address it feel free, but it's very minor so it's totally fine not to 😇
approved! good job! ✅ ✨
test('Search and list package groups', async ({ client }) => { | ||
const repoUrl = 'https://content-services.github.io/fixtures/yum/comps-modules/v1/'; | ||
const repoName = randomName(); | ||
let repoUuid: string | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could be declared just as a string then expected and asserted as non-null right after repo creation, this would eliminate the need to use the bang (non-null assertion) several times after that 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oo thank you! just pushed that up, lmk if that's what you had in mind 😄
Summary
Adds PW test for searching and listing package groups of a repo
Testing steps