Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-5617: package groups test #1018

Merged
merged 4 commits into from
Mar 19, 2025
Merged

HMS-5617: package groups test #1018

merged 4 commits into from
Mar 19, 2025

Conversation

xbhouse
Copy link
Contributor

@xbhouse xbhouse commented Mar 11, 2025

Summary

Adds PW test for searching and listing package groups of a repo

Testing steps

  • Tests pass
  • Covers all cases covered by associated IQE test in Jira

@jlsherrill
Copy link
Member

@xbhouse xbhouse force-pushed the 5617 branch 5 times, most recently from cd6bfa2 to fd19c0f Compare March 12, 2025 15:12
@xbhouse xbhouse marked this pull request as ready for review March 12, 2025 15:16
@xbhouse xbhouse force-pushed the 5617 branch 2 times, most recently from d3de9e5 to 4a61bcf Compare March 13, 2025 15:05
Copy link
Contributor

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice work on migrating and upgrading/extending the test! 👏🏼🎉
just one tiny nit 👀 if you wanted to address it feel free, but it's very minor so it's totally fine not to 😇

approved! good job! ✅ ✨

test('Search and list package groups', async ({ client }) => {
const repoUrl = 'https://content-services.github.io/fixtures/yum/comps-modules/v1/';
const repoName = randomName();
let repoUuid: string | undefined;
Copy link
Contributor

@dominikvagner dominikvagner Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this could be declared just as a string then expected and asserted as non-null right after repo creation, this would eliminate the need to use the bang (non-null assertion) several times after that 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oo thank you! just pushed that up, lmk if that's what you had in mind 😄

@swadeley swadeley merged commit e63097d into content-services:main Mar 19, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants