-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-4934: Add modules to introspected data #922
base: main
Are you sure you want to change the base?
Conversation
a3c0075
to
b276d0d
Compare
/retest |
@jlsherrill this failed to build |
@swadeley yes, it will fail to build until content-services/yummy#31 is merged and i update it to use the new yummy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I search for a stream that doesn't exist, I see null as the response. Would empty list be better? I think that's what I would've expected
good call, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed if I create and introspect a repository before checking-out this PR, then checkout this PR and re-introspect, the module streams don't get added because the repository hasn't changed (I suspect)
good call, updated! |
Summary
Adds module streams as searchable for introspected repos
Testing steps
go get ./...
make db-migrate-up
make repos-import
go run cmd/external-repos/main.go introspect go run cmd/external-repos/main.go introspect https://cdn.redhat.com/content/dist/rhel8/8/x86_64/appstream/os
go run cmd/external-repos/main.go introspect go run cmd/external-repos/main.go introspect https://cdn.redhat.com/content/dist/rhel9/9/x86_64/appstream/os
feel free to play with the search and rpm_names