Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-5024: add use template modal #403

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

rverdile
Copy link
Contributor

@rverdile rverdile commented Dec 23, 2024

Summary

Adds a "use template" button in the top left of the template details page that opens a modal with different sets of instructions on how to use templates.

image
image
image
image

Testing steps

@jlsherrill
Copy link
Member

@jlsherrill
Copy link
Member

jlsherrill commented Jan 3, 2025

This looks great, a couple of things to mention:

  1. For the first method, we probably should mention that subscription-manager refresh is needed after the steps which associates the system to the template
  2. https://issues.redhat.com/browse/RHINENG-14351 is merged, so we can mention via the first method that you can use the UI to associate the system OR use this new api:
PATCH /template/$TEMPLATE_UUID/subscribed-systems  

but we could fill in the $TEMPLATE_UUID with the actual UUID. I haven't tested this yet to confirm it works, i can do that on monday. So it could just show the curl command which trigger the association.

  1. for the curl and ansible method, we probably want to mention that system advisory information will not be available via the patch application

@rverdile rverdile marked this pull request as ready for review January 6, 2025 14:50
@rverdile
Copy link
Contributor Author

rverdile commented Jan 6, 2025

updated and updated the screenshots

@swadeley
Copy link
Member

swadeley commented Jan 8, 2025

/restest

@swadeley
Copy link
Member

swadeley commented Jan 8, 2025

/retest

@jlsherrill
Copy link
Member

I think there should be a space between these two buttons:
image

For the curl and ansible tabs, could you add an alert/warning box with something like:

Consuming a template in this way will result in the system not reporting applicable errata properly within Insights.  

@rverdile
Copy link
Contributor Author

rverdile commented Jan 8, 2025

updated!

@jlsherrill
Copy link
Member

Apologies i didn't think about this prior, but one small adjustment, now that "Patch" isn't actually a navigation item, it may make more sense to say "System advisory information will not be available via Systems" and have Systems be a link which links to /insights/patch/systems

IDK that users will necessarily think of "Patch" as an application now that it doesn't have a nav entry.

@jlsherrill
Copy link
Member

everything else looks great!

@rverdile
Copy link
Contributor Author

rverdile commented Jan 8, 2025

updated!

image

@swadeley
Copy link
Member

swadeley commented Jan 9, 2025

Hi

buttons have space between them:
image

the three tabs:

Insights:
image

curl:
image

Ansible:
image

@swadeley
Copy link
Member

swadeley commented Jan 9, 2025

Hi @jlsherrill

URLs are hardcoded I take it, no stage or ephemeral support then. OK?

@swadeley swadeley merged commit f85a500 into content-services:main Jan 9, 2025
6 of 8 checks passed
@rverdile rverdile deleted the template-uses branch January 9, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants