Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMS-5197: Fixes List snapshot being disabled for read only users #407

Merged
merged 2 commits into from
Jan 10, 2025
Merged

HMS-5197: Fixes List snapshot being disabled for read only users #407

merged 2 commits into from
Jan 10, 2025

Conversation

Andrewgdewar
Copy link
Member

@Andrewgdewar Andrewgdewar commented Jan 8, 2025 •
edited
Loading

Summary

Small change to update permissions to allow read-only users to view snapshots

Testing steps

  • Get a read -only user, check before and after this change.
  • With this change they should now be permitted to look at the snapshotList within the kebab for each repository.

@swadeley
Copy link
Member

swadeley commented Jan 9, 2025 •
edited
Loading

Hi

lgtm

Screenshot at 2025-01-09 14-46-36

image

@swadeley
Copy link
Member

swadeley commented Jan 9, 2025

/retest

@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/HMS-5197

swadeley
swadeley approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@swadeley swadeley merged commit 0785455 into content-services:main Jan 10, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swadeley swadeley swadeley approved these changes

Assignees
No one assigned
Labels
qe-testing-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andrewgdewar @swadeley @jlsherrill