doesn't create deferred struct until we parse arguments #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c77546 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dkozma
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Awesome job finding the issue so quickly - just one minor change before you merge, as well as one question to make sure I understand things properly.
Edit: Also I forgot to mention - please create a changeset before merging as mentioned above, since that process will automatically handle versioning.
dyro
force-pushed
the
dyross/CAI-4527
branch
3 times, most recently
from
106ac45 to
a276e49
Compare
dyro
force-pushed
the
dyross/CAI-4527
branch
from
a276e49 to
4c77546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs in provided to us by the reporter of the ticket included this error:
This occurs when a
Deferredstruct is created but not settled. Our code was creating the deferred values, then parsing arguments of the JS invocation of our APIs. If this parsing failed, thedefferedvalue would never be settled, which causes the panic. The added test will fail if thedeferredvalue is not settled.