Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce DynamicAssertion trait #566

Merged
merged 17 commits into from
Nov 15, 2024
Merged

feat: Introduce DynamicAssertion trait #566

merged 17 commits into from
Nov 15, 2024

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe requested a review from gpeacock August 20, 2024 00:01
@scouten-adobe scouten-adobe self-assigned this Aug 20, 2024
@scouten-adobe scouten-adobe changed the title Introduce DynamicAssertion trait feat: Introduce DynamicAssertion trait Oct 7, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.61151% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (a15f224) to head (622c163).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/store.rs 88.88% 14 Missing ⚠️
sdk/src/dynamic_assertion.rs 25.00% 3 Missing ⚠️
sdk/src/signer.rs 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
+ Coverage   81.77%   81.79%   +0.01%     
==========================================
  Files         100      101       +1     
  Lines       30801    30939     +138     
==========================================
+ Hits        25189    25307     +118     
- Misses       5612     5632      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gpeacock
gpeacock reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than needing some comments. I'll start the rework to move things into the Signer.

scouten-adobe and others added 3 commits October 28, 2024 15:43
@scouten-adobe
Follow up to code review feedback from @gpeacock
50349c6
@gpeacock
feat: Adds dynamic_assertions method to Signer traits.
074ef7b 
Updates unit test to use Signer based dynamic assertions.
Removes add_dynamic_assertion functionality from Store.
@gpeacock
Merge branch 'dynamic-assertion' of https://github.com/contentauth/c2…
f5f7ebf 
…pa-rs into dynamic-assertion
scouten-adobe
scouten-adobe commented Oct 29, 2024
View reviewed changes
Copy link
Collaborator Author

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about supporting DynamicAssertion in the non-async Signer case; otherwise, this looks spot on.

sdk/src/signer.rs Show resolved Hide resolved
@scouten-adobe scouten-adobe marked this pull request as ready for review November 1, 2024 18:53
gpeacock
gpeacock approved these changes Nov 15, 2024
View reviewed changes
sdk/src/signer.rs Show resolved Hide resolved
@gpeacock gpeacock merged commit bbd569f into main Nov 15, 2024
26 checks passed
@gpeacock gpeacock deleted the dynamic-assertion branch November 15, 2024 19:04
@scouten-adobe scouten-adobe mentioned this pull request Nov 15, 2024
Closed
This was referenced Dec 5, 2024
Closed
Closed
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeacock gpeacock gpeacock approved these changes

@mauricefisher64 mauricefisher64 Awaiting requested review from mauricefisher64

Assignees

@scouten-adobe scouten-adobe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scouten-adobe @gpeacock