-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Reorganization #689
base: main
Are you sure you want to change the base?
doc: Reorganization #689
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 81.52% 81.51% -0.01%
==========================================
Files 104 104
Lines 30614 30614
==========================================
- Hits 24958 24956 -2
- Misses 5656 5658 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments added
* `chore` | ||
* `ci` | ||
* `docs` | ||
* `feat` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we allowing all these? I thought there were only chore, docs, feat and fix.
|
||
### Enabling | ||
|
||
<!-- This requirement should go away with actual 1.0 release, right? --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will go away soon!
| | set_claim_generator_info | | | | | | ||
| | set_format | | | | | | ||
| | set_remote_url | | X | | | | ||
| | set_no_embed | | X | | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ now supports set_remote_url, set_no_embed, data_hashed_placeholder and sign_data_hashed_embeddable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually need to update a bunch of things on this chart, so just submit as is and I'll follow up.
Changes in this pull request
Create new docs directory and move some content from README to new files there:
For details, see https://wiki.corp.adobe.com/display/CAI/Rust+library+docs.
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.