Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move signing_alg_from_sign1 into c2pa-crypto #795

Merged
merged 1 commit into from
Dec 23, 2024

feat: Move `signing_alg_from_sign1` into `c2pa-crypto`

ccc3004
Select commit
Loading
Failed to load commit list.
Merged

feat: Move signing_alg_from_sign1 into c2pa-crypto #795

feat: Move `signing_alg_from_sign1` into `c2pa-crypto`
ccc3004
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 1s

80.68% (+0.00%) compared to f8ba3fb

View this Pull Request on Codecov

80.68% (+0.00%) compared to f8ba3fb

Details

Codecov Report

Attention: Patch coverage is 39.28571% with 17 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (f8ba3fb) to head (ccc3004).

Files with missing lines Patch % Lines
internal/crypto/src/cose/sign1.rs 33.33% 16 Missing ⚠️
sdk/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files         117      117           
  Lines       31046    31044    -2     
=======================================
- Hits        25048    25047    -1     
+ Misses       5998     5997    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.