Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move COSE timestamp generation into c2pa_crypto #803

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 64 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (66b57b5) to head (aaf3677).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/crypto/src/cose/sigtst.rs 0.00% 37 Missing ⚠️
internal/crypto/src/time_stamp/provider.rs 0.00% 22 Missing ⚠️
sdk/src/signer.rs 66.66% 3 Missing ⚠️
sdk/src/cose_sign.rs 80.00% 1 Missing ⚠️
sdk/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   80.83%   80.04%   -0.80%     
==========================================
  Files         118      117       -1     
  Lines       30951    30953       +2     
==========================================
- Hits        25019    24775     -244     
- Misses       5932     6178     +246     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe merged commit 25c89ed into main Dec 29, 2024
28 of 30 checks passed
@scouten-adobe scouten-adobe deleted the move-timestamp-gen branch December 29, 2024 02:28
@scouten-adobe scouten-adobe mentioned this pull request Dec 26, 2024
@scouten-adobe scouten-adobe mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant