Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Leverage new Manifest & Ingredient, add Ingredient creation. #107

Merged
merged 8 commits into from
Mar 16, 2023

Conversation

gpeacock
Copy link
Contributor

@gpeacock gpeacock commented Mar 2, 2023

Changes in this pull request

Leverage new Manifest & Ingredient, add Ingredient creation.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #107 (eadac33) into main (0ccf21b) will decrease coverage by 3.10%.
The diff coverage is 84.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   78.17%   75.07%   -3.10%     
==========================================
  Files           5        3       -2     
  Lines         394      325      -69     
==========================================
- Hits          308      244      -64     
+ Misses         86       81       -5     
Impacted Files Coverage Δ
src/info.rs 63.15% <50.00%> (ø)
src/main.rs 70.89% <79.26%> (+4.47%) ⬆️
src/signer.rs 93.67% <92.85%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very minor tweaks, otherwise 👍

src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@dyro dyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Nice!

Cargo.toml Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@gpeacock gpeacock merged commit e228213 into main Mar 16, 2023
@gpeacock gpeacock deleted the gpeacock/resource_store branch March 16, 2023 00:17
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
…auth/c2patool#107)

* integration with resource_stores in c2pa_rs 0.17.0
* Add --ingredient option to generate ingredients
* Add SignConfig, remove ManifestConfig
* struct-op to clap conversion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants