Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

Fix windows release #132

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix windows release #132

merged 2 commits into from
Jul 25, 2023

Conversation

jackfarzan
Copy link
Collaborator

Changes in this pull request

Switch from tar/compress to 7z for windows release

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Switch from tar/compress to 7z for windows release
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #132 (30c87bc) into main (74220bf) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   83.91%   83.91%           
=======================================
  Files           3        3           
  Lines         373      373           
=======================================
  Hits          313      313           
  Misses         60       60           

Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a corruption of the change. I approve the Compress-Archive change, but not the 7z thing

@jackfarzan
Copy link
Collaborator Author

This looks like a corruption of the change. I approve the Compress-Archive change, but not the 7z thing

Here's an example of it running successfully with 7z https://github.com/jackfarzan/c2patool/actions/runs/5658765421/job/15330803932

Compress-Archive does not exist on the GH windows runner.

@jackfarzan jackfarzan merged commit 33fce98 into main Jul 25, 2023
@jackfarzan jackfarzan deleted the fix-win-upload branch July 25, 2023 17:50
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
* Fix windows release

Switch from tar/compress to 7z for windows release

* Added 7zip note
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants