This repository has been archived by the owner on Dec 11, 2024. It is now read-only.
Integrate with c2pa-rs 0.32.0, various test case fixes. #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update c2pa-rs and remove xmp_write feature.
dyro
approved these changes
May 7, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 44.18% 44.18%
=======================================
Files 7 7
Lines 722 722
=======================================
Hits 319 319
Misses 403 403 ☔ View full report in Codecov by Sentry. |
scouten-adobe
pushed a commit
to contentauth/c2pa-rs
that referenced
this pull request
Dec 10, 2024
…c2patool#175) * Added error message for manifest without output target. Update c2pa-rs and remove xmp_write feature. * Update to c2pa-rs 0.32.0, with various fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate with c2pa-rs 0.32.0, various test case fixes.
The sidecar option when used with remote was incorrectly embedding a manifest.
An error will now be displayed if you try to use -c or -m manifests without an output target.
At one point we supported a preview mode, but that is no longer supported. The error replaces empty output.