Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

(IGNORE) Clarify use of test cert/key and general doc edits #193

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

crandmck
Copy link
Collaborator

@crandmck crandmck commented Jul 9, 2024

Doc-only PR to try to clarify use of test cert/key when using c2patool, along with numerous clean up edits.

@crandmck crandmck requested a review from dyro July 9, 2024 22:13
@crandmck crandmck changed the title Crandmck/doc update (IGNORE) Clarify use of test cert/key and general doc edits Jul 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.68%. Comparing base (eda7bc5) to head (1432f1b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   48.68%   48.68%           
=======================================
  Files           4        4           
  Lines         684      684           
=======================================
  Hits          333      333           
  Misses        351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crandmck crandmck requested a review from gpeacock July 9, 2024 23:11
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (comment added) but Maurice should look over the trust list comments.

README.md Outdated Show resolved Hide resolved
@crandmck crandmck requested a review from mauricefisher64 July 10, 2024 18:12
@crandmck
Copy link
Collaborator Author

@mauricefisher64 I removed the Example column from the table in the "Configuring trust support" section because it made the other columns very narrow and hard to read. The example values are very straightforward anyway... I also changed the wording a bit and added another example to help clarify.

@gpeacock gpeacock merged commit 684f8d1 into main Jul 22, 2024
13 checks passed
@gpeacock gpeacock deleted the crandmck/doc-update branch July 22, 2024 15:57
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
…h/c2patool#193)

* README edits

* README edits

* Edits per Gavin

* Remove example col from table for readability

* Add css class to trust options table

---------

Co-authored-by: Rand McKinney <rmckinne@adobe.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants