-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 48.68% 47.89% -0.79%
==========================================
Files 4 4
Lines 684 666 -18
==========================================
- Hits 333 319 -14
+ Misses 351 347 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move the sign_fragment and verify_fragment to a fragment.rs file, but since e need to restructure everything for subcommands anyway, no need to do that now.
Hello, I got an error message (Error: glob patterns only allowed when using "fragment" command) when adding a manifest to a JPG since upgrated to v 0.9.8. I had no problem with the v 0.9.7 and the same JPG. Could this be a regression in version 0.9.8? Thanks a lot. Regards,Xue |
* Initial fragment support * code review fixes
Changes in this pull request
New commands to add and validate BMFF fragmented assets. Support for globing to enables processing of complete DASH hierarchies.
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.