Skip to content
This repository has been archived by the owner on Dec 11, 2024. It is now read-only.

(IGNORE) Update README.md #54

Merged
merged 7 commits into from
Sep 2, 2022
Merged

(IGNORE) Update README.md #54

merged 7 commits into from
Sep 2, 2022

Conversation

crandmck
Copy link
Collaborator

Changes in this pull request

General edit of README, starting from version from #53.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #54 (6dbbd12) into main (df14a10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   72.60%   72.60%           
=======================================
  Files           3        3           
  Lines         230      230           
=======================================
  Hits          167      167           
  Misses         63       63           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crandmck
Copy link
Collaborator Author

@gpeacock @scouten-adobe I am on PTO all next week, so once this is approved, please feel free to merge it in my absence. If substantial changes are required, I can make them when I return.

@crandmck
Copy link
Collaborator Author

crandmck commented Sep 1, 2022

I know everyone's super busy, but I would appreciate a quick look when you have a moment. Thanks!

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great. I do have a few minor details that I'd like to see considered.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is SO much better, thank you! Added some comments about required changes

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@crandmck
Copy link
Collaborator Author

crandmck commented Sep 1, 2022

Thanks for the comments @scouten-adobe and @gpeacock! I believe I addressed all your comments.

@scouten-adobe scouten-adobe changed the title [IGNORE] Update README.md (IGNORE) Update README.md Sep 1, 2022
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more required changes I missed the first time

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@crandmck
Copy link
Collaborator Author

crandmck commented Sep 2, 2022

Thanks for catching those @gpeacock, I updated per your comments.

@gpeacock gpeacock merged commit 502c72c into main Sep 2, 2022
@gpeacock gpeacock deleted the crandmck/edit-readme branch September 2, 2022 20:42
@crandmck crandmck mentioned this pull request Sep 7, 2022
scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
* Update README.md
Co-authored-by: Rand McKinney <rmckinne@adobe.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants