Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate multiple md files from c2patool repo #77

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Conversation

crandmck
Copy link
Collaborator

@crandmck crandmck commented Aug 15, 2023

Changes in this pull request

This PR fetches new .md files (added in below noted PR) from c2patool repo and creates pages on the doc site for them, with sidebar entries.

This PR is paired with contentauth/c2patool#136.

Once that PR is merged:

  • I will remove the commented lines in scripts/fetch-readme.js that specify the chunk-docs
  • Then we can land this PR

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

@crandmck
Copy link
Collaborator Author

crandmck commented Aug 23, 2023

contentauth/c2patool#136 landed, but but there was a minor issue in the Docusaurus custom styling. Oops.
I fixed in contentauth/c2patool#138. That needs to land before we can land this.

Remove file from c2patool repo that shouldn't be checked in .
Remove file from c2patool repo that shouldn't be checked in .
Remove file from c2patool repo that shouldn't be checked in .
@github-actions github-actions bot temporarily deployed to pull request August 25, 2023 21:42 Inactive
@crandmck crandmck requested a review from dkozma August 25, 2023 21:45
@crandmck
Copy link
Collaborator Author

@crandmck crandmck changed the title [WIP - DON'T MERGE YET] Integrate multiple md files from c2patool repo Integrate multiple md files from c2patool repo Aug 25, 2023
Copy link

@dkozma dkozma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkozma dkozma merged commit 4584452 into main Aug 28, 2023
@dkozma dkozma deleted the c2patool-md-files branch August 28, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants