-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address deprecated function warning when listing content types #129
Conversation
a84ce75
to
988c616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Great job! I had a minor comment
988c616
to
71f0976
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 82.14% 82.32% +0.18%
==========================================
Files 56 57 +1
Lines 1120 1143 +23
==========================================
+ Hits 920 941 +21
- Misses 200 202 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Can you add a test to make sure that the correct environment id is set
0d402bd
to
b336f67
Compare
b336f67
to
a29050e
Compare
🎉 This PR is included in version 0.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Be more Environment aware.
Description
Motivation and Context