Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecated function warning when listing content types #129

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

makinwab
Copy link
Contributor

@makinwab makinwab commented Mar 13, 2019

Summary

Be more Environment aware.

Description

  • Get content types via the environment vs space
  • Add new option, environment id, to specify the environment when listing content types
  • Update content type list cmd documentation with new options

Motivation and Context

  • Given the environment driven context, certain methods would only be available by an environment object hence deprecation warnings
  • Valuable to have context on which environment is active and which one is currently on when listing content types.
  • Nice to have, being able to list content types from a specific environment without having to switch to that environment.

@makinwab makinwab force-pushed the chore/deprecated-function branch from a84ce75 to 988c616 Compare March 13, 2019 11:20
@makinwab makinwab requested a review from Khaledgarbaya March 13, 2019 11:24
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great job! I had a minor comment

lib/cmds/content-type_cmds/list.js Outdated Show resolved Hide resolved
@makinwab makinwab force-pushed the chore/deprecated-function branch from 988c616 to 71f0976 Compare March 14, 2019 09:18
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #129 into master will increase coverage by 0.18%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   82.14%   82.32%   +0.18%     
==========================================
  Files          56       57       +1     
  Lines        1120     1143      +23     
==========================================
+ Hits          920      941      +21     
- Misses        200      202       +2
Impacted Files Coverage Δ
lib/cmds/content-type_cmds/list.js 95.23% <100%> (ø)
lib/cmds/space_cmds/environment_cmds/list.js 90.47% <75%> (-4.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76d168...a29050e. Read the comment docs.

@makinwab makinwab requested a review from Khaledgarbaya March 14, 2019 09:27
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Can you add a test to make sure that the correct environment id is set

@makinwab makinwab force-pushed the chore/deprecated-function branch from 0d402bd to b336f67 Compare March 14, 2019 11:26
@makinwab makinwab force-pushed the chore/deprecated-function branch from b336f67 to a29050e Compare March 14, 2019 11:32
@makinwab makinwab requested a review from Khaledgarbaya March 14, 2019 12:04
@makinwab makinwab merged commit 564d648 into master Mar 14, 2019
@makinwab makinwab deleted the chore/deprecated-function branch March 14, 2019 13:22
@phoebeschmidt
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants