Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: strictNullChecks #907

Merged
merged 2 commits into from
Oct 5, 2023
Merged

chore: strictNullChecks #907

merged 2 commits into from
Oct 5, 2023

Conversation

mayakarabula
Copy link
Member

@mayakarabula mayakarabula commented Oct 5, 2023 •
edited by ruderngespra
Loading

  • enable strict null checks

This includes some actual code changes:

  • several if clauses to double check existences of entities on sourceData or transformedSourceData.
  • adjust some evaluation logic for fallback locales (see comment)

@mayakarabula mayakarabula requested a review from a team as a code owner October 5, 2023 13:35
ruderngespra
ruderngespra approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ruderngespra ruderngespra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice pragmatic next step :)

@ruderngespra ruderngespra merged commit b651d84 into master Oct 5, 2023
2 checks passed
@ruderngespra ruderngespra deleted the chore/typescript-migration-part-11 branch October 5, 2023 15:15
@contentful-automation
Copy link

🎉 This PR is included in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruderngespra ruderngespra ruderngespra approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayakarabula @ruderngespra