fix: don't allow additional parameters in plain client (#2491)

lib/plain/wrappers/wrap.test-d.ts

@@ -0,0 +1,30 @@
+import { describe, expectTypeOf, it } from 'vitest'
+import type { OptionalDefaults } from './wrap'
+
+describe('OptionalDefaults', () => {
+  it('does not add props', () => {
+    type Result = OptionalDefaults<{
+      foo: string
+    }>
+
+    type Expected = {
+      foo: string
+    }
+
+    expectTypeOf<Expected>().toMatchTypeOf<Result>()
+  })
+
+  it('adds default props if available', () => {
+    type Result = OptionalDefaults<{
+      foo: string
+      environmentId: string
+    }>
+
+    type Expected = {
+      foo: string
+      environmentId?: string
+    }
+
+    expectTypeOf<Result>().toMatchTypeOf<Expected>()
+  })
+})

lib/plain/wrappers/wrap.ts

@@ -10,9 +10,7 @@ export type DefaultParams = {
  * @private
  */
 export type OptionalDefaults<T> = Omit<T, keyof DefaultParams> &
-  ('organizationId' extends keyof T ? { organizationId?: string } : Record<string, unknown>) &
-  ('spaceId' extends keyof T ? { spaceId?: string } : Record<string, unknown>) &
-  ('environmentId' extends keyof T ? { environmentId?: string } : Record<string, unknown>)
+  Partial<Pick<T, Extract<keyof T, keyof DefaultParams>>>
 
 /**
  * @private

package.json

@@ -37,10 +37,11 @@
     "check-types": "tsc",
     "lint": "eslint lib test --ext '.ts,.tsx,.js,.jsx'",
     "pretest": "rimraf coverage && npm run lint",
-    "test": "npm run test:cover-unit && npm run test:cover-integration && npm run test:size",
+    "test": "npm run test:cover-unit && npm run test:types && npm run test:cover-integration && npm run test:size",
     "test:cover-unit": "npm run test:unit -- --coverage",
     "test:cover-integration": "npm run test:integration -- --coverage",
     "test:unit": "npx vitest --project unit --run",
+    "test:types": "npx vitest --project types --run",
     "test:unit-watch": "npx vitest --project unit",
     "test:integration": "npx vitest --project integration --run --no-file-parallelism",
     "test:integration-watch": "npx vitest --project integration --no-file-parallelism",

tsconfig.json

@@ -9,7 +9,8 @@
     "isolatedModules": true,
     "esModuleInterop": true,
     "noImplicitThis": false,
-    "typeRoots": ["node_modules/@types"]
+    "typeRoots": ["node_modules/@types"],
+    "skipLibCheck": true
   },
   "include": ["lib", "global-types"],
   "typedocOptions": {

vitest.workspace.js

@@ -12,6 +12,17 @@ export default defineWorkspace([
       maxConcurrency: 10,
     },
   },
+  {
+    test: {
+      ...vitestConfig.test,
+      include: ['lib/**/*.test-d.ts'],
+      name: 'types',
+      maxConcurrency: 10,
+      typecheck: {
+        enabled: true,
+      },
+    },
+  },
   {
     test: {
       ...vitestConfig.test,