Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve test space deletion #1480

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

damienxy
Copy link
Contributor

Improves the deletion of test spaces created during integration tests.

Things done:

  • set lower threshold for space cleanup (10 minutes instead of 1 hour)
  • add missing space cleanup to tests that create test spaces
  • add a global before, as the after doesn't always run (e.g. when you stop the test run midway)

test/mocha-global.js Outdated Show resolved Hide resolved
Copy link
Member

@luizfonseca luizfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽
Nothing blocking from my side.

@damienxy damienxy merged commit a3b4bc5 into master Sep 13, 2022
@ghost
Copy link

ghost commented Sep 14, 2022

🎉 This PR is included in version 10.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Sep 14, 2022
@marcolink marcolink deleted the fix/integration-test-housekeeping branch January 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants