-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OAuth Application Endpoints [AHOY-3610] #2526
Merged
Annmary12
merged 4 commits into
master
from
feat/AHOY-3610-support-cma-client-for-oauth-applications-endpoint
Jan 30, 2025
Merged
Support OAuth Application Endpoints [AHOY-3610] #2526
Annmary12
merged 4 commits into
master
from
feat/AHOY-3610-support-cma-client-for-oauth-applications-endpoint
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
202f6e9
to
686b07b
Compare
piankovev
previously approved these changes
Jan 28, 2025
whitelisab
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎊 Just two small suggestions to update (renaming the endpoints file and fixing a small typo) and then two non-blocking questions
e964887
to
32c68a4
Compare
32c68a4
to
acb354f
Compare
…h-applications-endpoint
whitelisab
approved these changes
Jan 30, 2025
🎉 This PR is included in version 11.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhance the CMA JS Client to include support for the newly introduced OAuth application endpoints.
Description
Supports a new method called
accessToken
.For a plain client, it has the following functions.
getOAuthApplication({userId: 'testUserID', oauthApplicationId: 'testOAuthApplicationId'})
For nonplain clients, it has the following functions
oauthApplication.get({userId: 'testUserID', oauthApplicationId: 'testOAuthApplicationId'})
oauthApplication.getManyForUser({userId: 'testUserID'})
oauthApplication.create({userId: 'testUserID'}, {name: 'Test-Name', description: 'Test-Desc', scopes: ['content_management_manage'], redirectUri: 'https://redirect.uri.com', confidential: true})
oauthApplication.update({userId: 'testUserID', oauthApplicationId: 'testOAuthApplicationId'}, {name: 'Updated name'})
oauthApplication.delete({userId: 'testUserID', oauthApplicationId: 'testOAuthApplicationId'})
Motivation and Context
Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts