feat: add support for external references #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoudy91
previously approved these changes
Jul 31, 2024
mgoudy91
force-pushed
the
DANTE-1594
branch
2 times, most recently
from
5ab2bb7 to
5430926
Compare
mgoudy91
approved these changes
Jul 31, 2024
t-col
reviewed
Jul 31, 2024
Comment on lines
250
to
+257
| ? ResolvedEntryLink<Modifiers, Locales, LinkedEntry> | ||
| : Field extends EntryFieldTypes.EntryResourceLink<infer LinkedEntry> | ||
| ? ResolvedEntryResourceLink<Modifiers, Locales, LinkedEntry> | ||
| : Field extends EntryFieldTypes.AssetLink | ||
| ? ResolvedAssetLink<Modifiers, Locales> | ||
| : BaseFieldMap<Field> | ||
| : Field extends EntryFieldTypes.ExternalResourceLink | ||
| ? { sys: ResourceLink<string> } | ||
| : Field extends EntryFieldTypes.AssetLink | ||
| ? ResolvedAssetLink<Modifiers, Locales> | ||
| : BaseFieldMap<Field> |
There was a problem hiding this comment.
is there no other way to represent this? 😬
There was a problem hiding this comment.
What do you mean by represent?
t-col
approved these changes
Jul 31, 2024
|
🎉 This PR is included in version 10.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for external references.
Description
Since these aren’t resolved they skip the
withoutUnresolvedLinksbehavior and are always kept.I’ve only updated the
parseEntriespart of the integration tests because it’s enough to cover the simple logic we currently have. The underlying behavior is the same forgetEntriesanyway. If we complicate the logic in the future we can expand the tests as well.