Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect typing for unresolved links for taxonomy [] #2401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: incorrect typing for unresolved links for taxonomy [] #2401

wants to merge 1 commit into from

Conversation

luizfonseca
Copy link
Member

Summary

  • Fixes the typing for Link objects from the taxonomy API. They are returned as "UnresolvedLinks" (where the parent key is sys)

Description

  • Change Link type to UnresolvedLink in types/concept.ts and types/concept-schemes.ts

Motivation and Context

  • Incorrect typing would lead to incorrect handling of the response objects.

Todos

  • N/A

Screenshots (if appropriate):

  • N/A

@luizfonseca luizfonseca self-assigned this Dec 12, 2024
@luizfonseca luizfonseca requested a review from a team as a code owner December 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiamStokingerContentful LiamStokingerContentful Awaiting requested review from LiamStokingerContentful

At least 1 approving review is required to merge this pull request.

Assignees

@luizfonseca luizfonseca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luizfonseca