Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add optional environment SpaceLink to Sys interface #920

Merged
merged 4 commits into from
Oct 5, 2021
Merged

fix(types): add optional environment SpaceLink to Sys interface #920

merged 4 commits into from
Oct 5, 2021

Conversation

mtchalim
Copy link
Contributor

@mtchalim mtchalim commented Oct 1, 2021 •
edited
Loading

Raw CDA responses include an environment field in each entity's sys field, which is not currently reflected in the Sys typedef. This PR introduces environment as an optional SpaceLink in the Sys interface, which should better support typing CDA response entities.

@ruderngespra
Copy link
Contributor

Thanks for reporting this! As this is an EnvironmentLink with a different linkType I slightly adjusted your suggestion (and restructured the other EntityLink types). Let me know if this makes sense to you!

@mtchalim
Merge pull request #1 from contentful/support-cda-response-type
a24b716 
fix(types): adjust link types and add EnvironmentLink
@mtchalim
Copy link
Contributor Author

mtchalim commented Oct 4, 2021

Thanks for reporting this! As this is an EnvironmentLink with a different linkType I slightly adjusted your suggestion (and restructured the other EntityLink types). Let me know if this makes sense to you!

Absolutely, thank you!

@ruderngespra ruderngespra requested a review from marcolink October 5, 2021 07:11
marcolink
marcolink approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@marcolink marcolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great - 🚢

@ruderngespra ruderngespra merged commit 78d77ec into contentful:master Oct 5, 2021
@ghost
Copy link

ghost commented Oct 5, 2021

🎉 This PR is included in version 9.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcolink marcolink marcolink approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtchalim @ruderngespra @marcolink