Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip set_selection onChange events #1443

Merged
merged 6 commits into from
Jul 12, 2023
Merged

fix: skip set_selection onChange events #1443

merged 6 commits into from
Jul 12, 2023

Conversation

z0al
Copy link
Member

@z0al z0al commented Jul 10, 2023 •
edited
Loading

Re-implemented the way we handle subscribing to onChange events. Previously, we used to skip set_selection events, but I mistakenly removed it during the recent upgrade.

This PR brings back the logic.

@z0al z0al marked this pull request as ready for review July 11, 2023 08:50
@z0al z0al requested a review from a team as a code owner July 11, 2023 08:50
2wce
2wce approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@2wce 2wce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z0al z0al merged commit fb835a2 into master Jul 12, 2023
8 checks passed
@z0al z0al deleted the tol-1284/fix-e2e branch July 12, 2023 14:53
chrishelgert
chrishelgert approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@chrishelgert chrishelgert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YvesRijckaert YvesRijckaert YvesRijckaert left review comments

@chrishelgert chrishelgert chrishelgert approved these changes

@2wce 2wce 2wce approved these changes

@aodhagan-cf aodhagan-cf Awaiting requested review from aodhagan-cf

Assignees
No one assigned
Labels
package:rich-text tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@z0al @chrishelgert @2wce @YvesRijckaert