fix: bumping plate packages and react version to 18 [TOL-2415] #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aodhagan-cf
commented
Sep 30, 2024
•
aodhagan-cf
commented
- Bumping plate packages
- Updating to react v18, required as the cypress component test webpack build fails without it after bumping some of the plate packages
- Fixing cypress component test parallelism
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
github-actions
bot
added
package:_shared
package:date
package:reference
package:tags
labels
github-actions
bot
added
package:_test
package:boolean
package:checkbox
package:default-field-editors
package:dropdown
package:json
package:list
package:location
package:markdown
package:multiple-line
package:number
package:radio
package:rating
package:single-line
package:slug
package:url
labels
aodhagan-cf
changed the title
aodhagan-cf
changed the title
aodhagan-cf
commented
Sep 30, 2024
| @@ -71,7 +71,7 @@ jobs: | |||
| - run: | |||
| name: Run cypress component tests | |||
| command: | | |||
| TESTFILES=$(circleci tests glob cypress/component/**/*.ts | circleci tests split --split-by=timings --timings-type=filename | tr '\n' ',') | |||
| TESTFILES=$(circleci tests glob cypress/component/**/*.ts | circleci tests split --split-by=timings --timings-type=filename | awk '{if (NR>1) printf ","; printf "%s", $0} END {if (NR>0) printf " "}') | |||
There was a problem hiding this comment.
This is a known issue with cypress, if you end a CSV with a comma the cypress command ignores it and runs everything, we are actually running all tests but now in 3 containers instead of splitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.