chore(dependencies): bumping plate packages and react version to 18 [TOL-2415] #1756
Conversation
aodhagan-cf
commented
Sep 30, 2024
•
aodhagan-cf
commented
- Bumping plate packages
- Updating to react v18, required as the cypress component test webpack build fails without it after bumping some of the plate packages
- Fixing cypress component test parallelism
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
github-actions
bot
added
package:_shared
package:date
package:reference
package:tags
labels
github-actions
bot
added
package:_test
package:boolean
package:checkbox
package:default-field-editors
package:dropdown
package:json
package:list
package:location
package:markdown
package:multiple-line
package:number
package:radio
package:rating
package:single-line
package:slug
package:url
labels
aodhagan-cf
changed the title
aodhagan-cf
changed the title
| @@ -71,7 +71,7 @@ jobs: | |||
| - run: | |||
| name: Run cypress component tests | |||
| command: | | |||
| TESTFILES=$(circleci tests glob cypress/component/**/*.ts | circleci tests split --split-by=timings --timings-type=filename | tr '\n' ',') | |||
| TESTFILES=$(circleci tests glob cypress/component/**/*.ts | circleci tests split --split-by=timings --timings-type=filename | awk '{if (NR>1) printf ","; printf "%s", $0} END {if (NR>0) printf " "}') | |||
There was a problem hiding this comment.
This is a known issue with cypress, if you end a CSV with a comma the cypress command ignores it and runs everything, we are actually running all tests but now in 3 containers instead of splitting
There was a problem hiding this comment.
wonder if we have this issue in other projects too? (experience-packages, ..)
There was a problem hiding this comment.
experience-packages is not parallelised but yeah it's possible with the combo of test field splitting in circleci
aodhagan-cf
changed the title
Co-authored-by: Chris Helgert <chrishelgert@users.noreply.github.com>
packages/_test/package.json
Outdated
| @@ -46,7 +46,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@contentful/app-sdk": "^4.29.0", | |||
| "react": ">=16.8.0" | |||
| "react": ">=17.0.2" | |||
There was a problem hiding this comment.
here too :D (and in the other ones too :D)
packages/rich-text/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@contentful/field-editor-test-utils": "^1.5.1", | ||
| "@contentful/rich-text-react-renderer": "^15.16.4", | ||
| "@types/is-hotkey": "^0.1.6", | ||
| "@udecode/plate-test-utils": "^3.2.0", | ||
| "prism-react-renderer": "2.4.0", | ||
| "react": ">=16.14.0" | ||
| "react": "17.0.2" |
There was a problem hiding this comment.
dev should be react 18 right?
There was a problem hiding this comment.
potentialy we don't even need it as it's in the global package.json?
There was a problem hiding this comment.
Yeah I think we don't need to change this, but will anyways. Rich text is the only package that even has a react dev dependency
