-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom plugins for slate #702
base: master
Are you sure you want to change the base?
Conversation
Hi @mcheng-caring, thanks for the PR 👍 This approach seems fine to me, looks like you'll need to add JSYK, we're currently working on upgrading the rich text editor. When it's ready (should be sometime later this year), this will be a major version bump that will not break compatibility with the existing format, but this means you may need to rewrite any custom plugins built using this approach. |
Hey @mcheng-caring, any update on this? I'm currently looking into a solution for code blocks for a blog and thinking around ways to do this, I created my own field that has a code editor but would be great to do it in the rich text editor directly, thanks |
Hi @JimmyHowe, at my company, we've been using a fork with the code change from this PR for over a year now with success. I haven't had the time to loop back to this PR to check what tests were failing due to time constraints and because we deprioritize getting this PR through due to the news that rich text editor was supposed to have been updated (AFAIK, the update is still only present in the |
Marking pull request as stale since there was no acitivty for 30 days |
Marking pull request as stale since there was no activity for 30 days |
Description
Adds a
customPlugins
prop to theRichTextEditor
component. This allows the user to override existing node renderers or and/or add their own node renderers used by Slate.