Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Note to outside contributors for forma websites #2343

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

bgutsol
Copy link
Contributor

@bgutsol bgutsol commented Nov 30, 2022

Purpose of PR

Replicate #2323 since that one is failing on CI

@bgutsol bgutsol requested review from a team and Lelith as code owners November 30, 2022 09:21
@bgutsol bgutsol requested review from massao and mshaaban0 November 30, 2022 09:21
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2022

⚠️ No Changeset found

Latest commit: 6dc2057

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 122.77 KB (0%) 2.5 s (0%) 79 ms (-11.88% 🔽) 2.6 s
Module 119.38 KB (0%) 2.4 s (0%) 60 ms (-19.96% 🔽) 2.5 s

@denkristoffer
Copy link
Collaborator

I think the better solution here is to provide a JSON export that users can load into their own space with the right content model, and then add some docs around getting that up and running instead.

@bgutsol
Copy link
Contributor Author

bgutsol commented Nov 30, 2022

I think the better solution here is to provide a JSON export that users can load into their own space with the right content model, and then add some docs around getting that up and running instead.

Good idea @denkristoffer, would you mind adding it to our Forma36 backlog?

@bgutsol bgutsol merged commit 505074f into main Nov 30, 2022
@bgutsol bgutsol deleted the docs-website branch November 30, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants