Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace placeImg with static image on Asset examples #2404

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

massao
Copy link
Contributor

@massao massao commented Feb 16, 2023

Purpose of PR

Replace usage of placeimg with asset from Contentful's image service on Asset examples

@massao massao requested review from fabe and mshaaban0 February 16, 2023 13:22
@massao massao requested review from a team and Lelith as code owners February 16, 2023 13:22
@massao massao requested a review from denkristoffer February 16, 2023 13:22
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2023

⚠️ No Changeset found

Latest commit: e1e0075

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
forma-36 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 1:25PM (UTC)

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 121.33 KB (0%) 2.5 s (0%) 73 ms (-16.77% 🔽) 2.5 s
Module 118.12 KB (0%) 2.4 s (0%) 98 ms (+32.26% 🔺) 2.5 s

@denkristoffer denkristoffer merged commit 61a1f99 into main Feb 20, 2023
@denkristoffer denkristoffer deleted the fix/replace-placeimg-with-static-img branch February 20, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants