Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: less jest-axe configuration #2916

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

denkristoffer
Copy link
Collaborator

@denkristoffer denkristoffer commented Oct 18, 2024

Purpose of PR

Clean up some jest-axe configuration which makes it possible to get rid of our axeHelper and do import { axe } from 'jest-axe'; directly in tests.

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 8ab301d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Oct 30, 2024 10:16am

@denkristoffer denkristoffer marked this pull request as ready for review October 30, 2024 10:27
@denkristoffer denkristoffer requested review from damann and a team as code owners October 30, 2024 10:27
@denkristoffer denkristoffer requested review from cf-remylenoir and removed request for a team October 30, 2024 10:27
Copy link
Collaborator

@cf-remylenoir cf-remylenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@denkristoffer denkristoffer merged commit 4f7caab into next Nov 1, 2024
10 of 11 checks passed
@denkristoffer denkristoffer deleted the chore/less-axe-config branch November 1, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants