docs(IconButton): update public documentation + prop API [F36-1540] #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 73c9674 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cf-remylenoir
commented
Nov 26, 2024
| @@ -43,7 +43,7 @@ interface PageContentHeaderProps { | |||
| const getGithubIssueLink = (title) => { | |||
| const queryParams = { | |||
| title: `💬 Feedback - ${title}`, | |||
| assignees: 'burakukula,mshaaban0,denkristoffer,Lelith', | |||
| assignees: 'Lelith, veu, cf-remylenoir, damann', | |||
There was a problem hiding this comment.
We could replace the individuals with the team as soon as it is created.
There was a problem hiding this comment.
It does not seem to be possible at the moment, see https://github.com/orgs/community/discussions/57306
cf-remylenoir
commented
Nov 26, 2024
|
|
||
| In toolbars, action bars, and in all other space restricted containers we suggest using `IconButton` instead of `Button` component. | ||
| ### Tooltip |
There was a problem hiding this comment.
@damann I added the tooltip text you prepared in this section to include an example.
size-limit report 📦
|
cf-remylenoir
force-pushed
the
F36-1540-update-guidelines-for-icon-button
branch
from
26ae260 to
7ffe7c7
Compare
damann
previously approved these changes
Nov 27, 2024
damann
approved these changes
Nov 27, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Updates the
IconButtondocumentation and properties API description.Updated documentation: https://forma-36-git-f36-1540-update-guidelines-for-icon-button.colorfuldemo.com/components/icon-button
PR Checklist
readme.mdfile(s)