Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adopt product card v2 [MONET-1325] #215

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Conversation

marcolink
Copy link
Member

Purpose

Shopify App

Switch to new product card to display additional data.

Approach

Use latests build from @contentful/ecommerce-app-base and implement a new renderer for additional information.

Product - additional data

To display the price for a product, we take into account all prices of its variants, if there vary, we show a price range.

Collection - additional data

To display the number of products within a collection, we query the first 101 product ids (to keep the footprint small) of a collection. If the response has 101 items, we display > 100 for the products count. This stunt is unfortunately necessary, as there is no count pro provided by the Shopify API (if you know a better way, please change it).

Testing steps

I assume this has to be tested manually

Dependencies and/or References

This is based on contentful/apps#4534

Screenshots

Collection

Screenshot 2023-08-24 at 16 11 26 Screenshot 2023-08-24 at 16 11 33

Product

Screenshot 2023-08-24 at 16 11 51 Screenshot 2023-08-24 at 16 12 04

Variant

Screenshot 2023-08-24 at 16 26 56 Screenshot 2023-08-24 at 16 27 03

ToDo:
Once the foundational work is released, the @contentful/ecommerce-app-base dependency has to be updated, and the relativeDependencies removed.

@marcolink marcolink requested a review from a team as a code owner August 24, 2023 14:31
apps/shopify/src/additionalDataRenderer.js Outdated Show resolved Hide resolved
apps/shopify/src/additionalDataRenderer.js Outdated Show resolved Hide resolved
apps/shopify/src/skuResolvers.js Show resolved Hide resolved
apps/shopify/src/constants.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants