Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app action request function event handler type [EXT-5710] #706

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jjolton-contentful
Copy link
Contributor

@jjolton-contentful jjolton-contentful commented Oct 23, 2024

We needed to add generics to FunctionEventHandlers in order to support someone defining specific types for the AppActionCategory and AppActionRequestBody when defining a function handler for an appaction.call. This will ultimately fix a type error we are seeing in our app action function example.

@jjolton-contentful jjolton-contentful requested a review from a team as a code owner October 23, 2024 20:17
@whitelisab whitelisab changed the title fix: app action request function event handler type [EXT-00] fix: app action request function event handler type [EXT-5710] Oct 23, 2024
@whitelisab whitelisab merged commit e9e7071 into main Oct 23, 2024
7 checks passed
@whitelisab whitelisab deleted the fix/app-action-request-type branch October 23, 2024 21:32
contentful-automation bot added a commit that referenced this pull request Oct 23, 2024
## [3.9.1](v3.9.0...v3.9.1) (2024-10-23)

### Bug Fixes

* app action request function event handler type [EXT-5710] ([#706](#706)) ([e9e7071](e9e7071))
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 3.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants